-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Don't add single files to classpath #2553
Conversation
Suggest throwing an error (or perhaps a warning) if you filter something out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @crt-31 that a warning would be nice to have here.
I thinking that maybe we could just create a temp directory instead, so that would work nicely. I will work on that later |
9cde0c0
to
e908949
Compare
Actually, it might be easier to just copy those resources, let me try work on that. |
@tgodzik, are you then planning to edit the config format so that it has a way to map the resources to specific places in the 'jar'? (I hope so :)) |
That might be hard to do though, not planning to work on it now ufortunately. |
Do we have any build tool that supports this mapping from files to resource path? If not, then I don't think we need it in Bloop. In the original issue (#1631) it seems that sbt puts the resource file at the root of the jar. |
e908949
to
62c3487
Compare
I'll try sbt later today, but I could have sworn it allowed single file resource mapping. |
62c3487
to
a33d3e7
Compare
a33d3e7
to
b7fc29c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only jars and directories are excepted. In case of resources it will most likely be always a directory.